[oneMKL][BLAS] add out-of-place TRMM and TRSM #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeterel
reviewed
Mar 8, 2024
|
|
||
| .. rubric:: Input Parameters | ||
|
|
||
| queue |
There was a problem hiding this comment.
Did you check how these look after compiling? Indentation does not seem to match to in-place API descriptions.
mmeterel
reviewed
Mar 8, 2024
| Specifies whether ``A`` is on the left side of the matrix solve | ||
| (``side::left``) or on the right side (``side::right``). See :ref:`onemkl_datatypes` for more details. | ||
|
|
||
| upper_lower |
There was a problem hiding this comment.
Same comment as before about indentation. Also, these parameters have different name in in-place section, a typo from earlier. It would be good to align them, but it can be done separately too.
There was a problem hiding this comment.
The indentation does not seem to have any effect on rendered output, but I adjusted to make it all consistent. I also fixed the uplo / upper_lower thing to be consistent.
mmeterel
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds out-of-place TRMM and TRSM APIs to the spec. As an example, the new TRMM API supports operations of the form$C = \alpha AB + \beta C$ , with a similar change for TRSM.