[oneMKL][spblas] Add optimize_symv() and optimize_gemm() routines in oneMKL specification.
#499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerpatty
reviewed
Sep 8, 2023
|
I would like to wrap up the 1.3-provisional release. Is this ready for merging. |
|
@rscohn2 let me take one more pass at cleaning up language a little bit, it is 95% there in my opinion... :) |
spencerpatty
approved these changes
Sep 11, 2023
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
… in oneMKL specification. (uxlfoundation#499) * [oneMKL][spblas] add spec for oneapi::mkl::sparse::optimize_gemm() routine. * [oneMKL][spblas] add spec for oneapi::mkl::sparse::optimize_symv() routine. * minor fix. * [oneMKL][spblas] add explanation of why we propose two versions of optimize_gemm(). * Update source/elements/oneMKL/source/domains/spblas/gemmoptimize.rst * Apply suggestions from code review * fix whitespace issues --------- Co-authored-by: Spencer Patty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
In this PR, I'd like to add two optimization routines,
optimize_symv()andoptimize_gemm()into oneMKL specification.Details:
optimize_symv()API into oneMKL specification, which prepares optimization foroneapi::mkl::sparse::symv()API.optimize_gemm()API into oneMKL specification, which prepares optimization foroneapi::mkl::sparse::gemm()API.optimize_gemm()API, we propose two different routines; the first API will prepare optimization based on sparse input matrix only, and the other API will prepare optimization based on both sparse and dense input matrices.Sparse BLASmain page.