Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify str_arg_char template specialization #77

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Simplify str_arg_char template specialization #77

merged 2 commits into from
Oct 24, 2024

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented Oct 24, 2024

  • One string class parameter is used instead of the parameter pack
  • Simplified use of the str_arg constructor with string pointer and length parameters - length can now be any integer.
  • Use class template argument deduction with str_arg in test-str_arg.cpp.

* One string class parameter is used instead of the parameter pack

* Simplified use of the str_arg constructor with string pointer and
  length parameters - length can now be any integer.
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (e2ec706) to head (066d985).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.01%     
==========================================
  Files          14       14              
  Lines        2427     2422       -5     
  Branches      382      382              
==========================================
- Hits         2419     2414       -5     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CTAD - Class template argument deduction (since C++17)
@rmisev rmisev merged commit 066d985 into main Oct 24, 2024
26 checks passed
@rmisev rmisev deleted the str-arg branch October 24, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant