Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add str_arg_char specializations for ATL/MFC and Qt strings #74

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented Oct 12, 2024

Added support for ATL/MFC and Qt string input. To use them you need to include the header files listed in the table below instead of url.h:

Library Supported string types Include instead of url.h
ATL/MFC CSimpleStringT, CStringT, CFixedStringT url_for_atl.h
Qt QString, QStringView, QUtf8StringView url_for_qt.h

Qt example:

#include "upa/url_for_qt.h"
#include <QString>
#include <iostream>

int main() {
    QString str{"http://example.com/"};
    upa::url url{str};
    std::cout << url.href() << '\n';
    return 0;
}

To support string input from CStringT (ATL/MFC) and QString (Qt)
objects.
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (0f3e22e) to head (9d200ba).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   99.86%   99.67%   -0.20%     
==========================================
  Files          14       14              
  Lines        2306     2427     +121     
  Branches      383      382       -1     
==========================================
+ Hits         2303     2419     +116     
- Misses          3        8       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* CSimpleStringT, CFixedStringT

* For C++20 - any string derived from CSimpleStringT
* QStringView, QUtf8StringView

* add tests
@rmisev rmisev merged commit 9d200ba into main Oct 17, 2024
26 checks passed
@rmisev rmisev deleted the string-input branch October 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant