Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept UNC path without share-name #67

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Accept UNC path without share-name #67

merged 1 commit into from
Sep 3, 2024

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented Sep 3, 2024

Windows File Explorer accepts such UNC paths, and Chrome and Firefox convert them to file URLs.

Example of conversion: \\host-name -> file://host-name/

Windows File Explorer accepts such UNC paths, and Chrome and Firefox
convert them to file URLs.

Example of conversion: `\\host-name` -> `file://host-name/`
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (f8237d5) to head (aa55b33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          16       16           
  Lines        2375     2376    +1     
  Branches      387      387           
=======================================
+ Hits         2367     2368    +1     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisev rmisev merged commit aa55b33 into main Sep 3, 2024
24 checks passed
@rmisev rmisev deleted the unc-share-name branch September 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant