Rename all CamelCase functions to snake_case in the url_percent_encode.h #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* isCharInSet -> is_char_in_set * isIPv4Char -> is_ipv4_char * isHexChar -> is_hex_char
* HexCharToValue -> hex_char_to_num * DecodeEscaped -> decode_hex_to_byte
* AppendEscapedChar -> append_percent_encoded_byte * AppendUTF8EscapedChar -> append_utf8_percent_encoded_char * Remove AppendUTF8EscapedValue function and move its content to append_utf8_percent_encoded_char function * AppendStringOfType -> append_utf8_percent_encoded
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 99.72% 99.72% -0.01%
==========================================
Files 15 15
Lines 2217 2215 -2
==========================================
- Hits 2211 2209 -2
Misses 6 6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
isCharInSet->is_char_in_setisIPv4Char->is_ipv4_charisHexChar->is_hex_charHexCharToValue->hex_char_to_numDecodeEscaped->decode_hex_to_byteAppendEscapedChar->append_percent_encoded_byteAppendUTF8EscapedChar->append_utf8_percent_encoded_charAppendStringOfType->append_utf8_percent_encodedRemove
AppendUTF8EscapedValuefunction and move its content toappend_utf8_percent_encoded_charfunction. Update comments.