Refactor to use validation errors (enum class validation_errc) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation errors used are defined at: https://url.spec.whatwg.org/#validation-error Follows: whatwg/url@d84610f
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 99.09% 99.72% +0.63%
==========================================
Files 15 15
Lines 2202 2213 +11
==========================================
+ Hits 2182 2207 +25
+ Misses 20 6 -14
☔ View full report in Codecov by Sentry. |
* input examples from the https://url.spec.whatwg.org/#validation-error table for errors that cause failure * tests for better coverage of the ipv6_parse function
rmisev
added a commit
that referenced
this pull request
Oct 24, 2023
The URL standard changes from whatwg/url@3e8cd02 "Fix validation error when a URL has credentials but no host" are already included in the PR #13 commits b508f69 and 45293e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation errors used are defined at:
https://url.spec.whatwg.org/#validation-error
Follows: whatwg/url@d84610f