Ucdxml and TR42 #859
Ucdxml and TR42 #859
Conversation
|
Comment on June 6 is no longer valid - we're now ready for review. |
|
@macchiati @eggrobin @markusicu - Please can you review? |
| @@ -310,6 +313,15 @@ Unihan_Variants ; kSpoofingVariant | |||
| Unihan_Variants ; kTraditionalVariant | |||
| Unihan_Variants ; kZVariant | |||
There was a problem hiding this comment.
Should there be a line for kZhuang here? (In other words, are you getting any data for kZhuang?)
There was a problem hiding this comment.
The current version of UCDXML does not support kZhuang, just kZhuangNumeric.
Similar to Unikemet, we should add support either for the revised 16.0 UCDXML files, or for 17.
| cjkRSTUnicode ; kRSTUnicode | ||
| cjkReading ; kReading | ||
| cjkSrc_NushuDuben ; kSrc_NushuDuben | ||
| cjkTGT_MergedSrc ; kTGT_MergedSrc |
There was a problem hiding this comment.
Please revert this change: Tangut and Nüshu are not CJK, they should not have a cjk alias.
The name kReading is unfortunate (since this is really Nüshu-specific), but it is what it is.
I guess you should add the comment that I should have added saying that these are the fields from the Tangut and Nüshu sources files.
unicodetools/src/main/resources/org/unicode/props/ExtraPropertyAliases.txt
Show resolved
Hide resolved
PR to make it easy to see what changes have been made to support UCDXML.