Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templatize CollationTest.html #530

Merged
merged 1 commit into from
Aug 23, 2023
Merged

templatize CollationTest.html #530

merged 1 commit into from
Aug 23, 2023

Conversation

markusicu
Copy link
Member

like the ReadMe.txt files, replacing routine manual updates

Ken-Whistler
Ken-Whistler approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Ken-Whistler Ken-Whistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me to template the file this way, on the assumption that it will be clearly documented that all these templated files need to be systematically generated for deployment.

@markusicu markusicu merged commit 1926a16 into unicode-org:main Aug 23, 2023
9 checks passed
@markusicu markusicu deleted the uca15.1-final-CollationTest.html branch August 23, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ken-Whistler Ken-Whistler Ken-Whistler approved these changes

@eggrobin eggrobin eggrobin approved these changes

@echeran echeran Awaiting requested review from echeran

@Manishearth Manishearth Awaiting requested review from Manishearth

@macchiati macchiati Awaiting requested review from macchiati

@nedley nedley Awaiting requested review from nedley

@josh-hadley josh-hadley Awaiting requested review from josh-hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markusicu @eggrobin @Ken-Whistler