Add :test:function, :test:select, and :test:format function definitions #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Apr 15, 2024
eemeli
changed the title
|
As discussed during yesterday's call, it'd be better for the functions to more clearly depart from e.g. I also added details for what happens when a |
aphillips
reviewed
Apr 16, 2024
eemeli
changed the title
Merged
aphillips
reviewed
Apr 29, 2024
aphillips
reviewed
Apr 29, 2024
Co-authored-by: Addison Phillips <[email protected]>
sffc
reviewed
May 6, 2024
echeran
reviewed
May 7, 2024
echeran
reviewed
May 7, 2024
| #### Options | ||
|
|
||
| The only _option_ `:test:function` recognizes is `fd`, | ||
| a _digit size option_ for which only `0` and `1` are valid values. |
There was a problem hiding this comment.
Linkifying digit size just as "Number Operand" is being linkified 5 lines above. Helps short circuit questions like mine for the reader.
Suggested change
| a _digit size option_ for which only `0` and `1` are valid values. | |
| a [_digit size option_](/spec/registry.md#digit-size-options) for which only `0` and `1` are valid values. |
There was a problem hiding this comment.
Underscore italics are linkified when the spec is turned into HTML. That's what this is for.
aphillips
approved these changes
May 8, 2024
mihnita
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @mradbourne
Given that we shouldn't rely on
:numberand:datetimeproducing exact results but we still want to ensure that our interfaces with them work, let's add:test:numberand:test:pluralas well-defined functions intended for tests only, with exactly defined behaviour.This PR could be extended with test cases making use of these, but I figured it'd be more useful to consider the general case first, esp. in order to avoid conflicting with #767.