Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twoxhash to 2.0 #5709

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Manishearth
Copy link
Member

Supersedes #5706

@Manishearth Manishearth requested review from sffc and a team as code owners October 18, 2024 19:36
@sffc
Copy link
Member

sffc commented Oct 18, 2024

Not currently compatible with the repo MSRV.

@Manishearth
Copy link
Member Author

Yep, I plan to leave this PR open for now

@Manishearth Manishearth marked this pull request as draft October 18, 2024 19:53
@robertbastian
Copy link
Member

1.81 MSRV is far away, can we not keep draft PRs cluttering the repo for extended periods of time?

@sffc
Copy link
Member

sffc commented Oct 21, 2024

I think it's fine. We have old draft PRs.

@robertbastian
Copy link
Member

And we should clean them up. Most are more work to rebase than to do again, many are not even compatible with current designs anymore.

@sffc sffc removed their request for review November 2, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants