-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some scripts and regions to HelloWorldProvider #3936
Conversation
|
What can you demonstrate with serbian that you cannot demonstrate with one of the existing languages? |
Only that it is more interesting when a script is involved in the fallback. |
…ving to do with regions
provider/core/src/hello_world.rs
Outdated
@@ -108,6 +108,7 @@ impl HelloWorldProvider { | |||
("el", "Καλημέρα κόσμε"), | |||
("en", "Hello World"), | |||
("en+reverse", "Olleh Dlrow"), | |||
("en-GB", "’allo Mate!"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's ... borderline offensive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's intended as a cheesy string for demonstrating regional variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to flag emoji
I don't like this |
I'm making this PR primarily in response to feedback that we should be using HelloWorldProvider instead of Also, I kind-of like how this works even better than |
commit b62edfe Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:30:56 2023 +0200 regenerate test+bakeddata commit ba7a333 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:23:33 2023 +0200 add idx to segments commit bddf819 Author: Robert Bastian <[email protected]> Date: Fri Aug 25 21:45:28 2023 +0200 pen Cleaning up the workspace (unicode-org#3938) commit beae962 Author: Shane F. Carr <[email protected]> Date: Fri Aug 25 12:22:25 2023 -0700 Add some scripts and regions to HelloWorldProvider (unicode-org#3936)
commit 7e08042 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 15:03:39 2023 +0000 trait docs commit 8dff4d9 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:53:23 2023 +0000 more comments commit 6286c28 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:48:32 2023 +0000 regenerate testdata commit 5ba561d Merge: f942dfb ad8e54b Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:46:49 2023 +0000 Merge branch 'main' into tl-runtime commit f942dfb Author: Niels Saurer <[email protected]> Date: Mon Aug 28 13:57:29 2023 +0000 more docs for replaceable.rs commit cf82d85 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 12:38:25 2023 +0000 remove last unsafe in transliterator module commit 74e1e8f Author: Niels Saurer <[email protected]> Date: Mon Aug 28 05:07:08 2023 +0200 doc changes commit c5f521b Author: Niels Saurer <[email protected]> Date: Mon Aug 28 04:21:21 2023 +0200 factor out partially-invisible-vec semantics into Hide commit c33bc8d Author: Niels Saurer <[email protected]> Date: Mon Aug 28 03:16:44 2023 +0200 replaceable api changes commit 3932436 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 03:10:25 2023 +0200 safe replaceable-from-insertable getting commit 0ef369f Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:27:53 2023 +0200 fix backref bug commit 7822602 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:21:36 2023 +0200 improve perf by '25%' commit c88e2f4 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:18:37 2023 +0200 remove duplicate license header commit 88d037d Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:09:38 2023 +0200 avoid potential cursor safety issue commit ba16b35 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 00:38:40 2023 +0200 enforce no key matching after post matching commit 5370bc2 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 22:44:34 2023 +0200 remove eprintlns commit 7d1fb9e Author: Niels Saurer <[email protected]> Date: Sun Aug 27 22:34:57 2023 +0200 benchmarking commit 5e0e3b2 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 21:57:10 2023 +0200 refactor RepMatcher to avoid some index recomputations commit cd7091d Author: Niels Saurer <[email protected]> Date: Sun Aug 27 21:25:46 2023 +0200 switch to safer Matcher API commit 283ba60 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 15:52:03 2023 +0200 notes commit 3ccc422 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 14:46:58 2023 +0200 cursoroffset::byte safety commit d1f880d Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:28:50 2023 +0200 cleanup commit 2255447 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:21:28 2023 +0200 cleanup commit a03f2f8 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:14:30 2023 +0200 add convenience function commit 41b1fd0 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:06:04 2023 +0200 add notes commit a270ce5 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 02:42:33 2023 +0200 300k lines is maybe a bit much commit fe5ed45 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 02:35:46 2023 +0200 add cldr testData tests for supported locales commit 2c12542 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 01:17:09 2023 +0200 use other crates' baked providers commit 2b3d91e Author: Niels Saurer <[email protected]> Date: Sun Aug 27 01:03:33 2023 +0200 make normalization tests pass, but baked is probably wrong commit 437443b Author: Niels Saurer <[email protected]> Date: Sun Aug 27 00:16:07 2023 +0200 add notes commit 66be38b Author: Niels Saurer <[email protected]> Date: Sat Aug 26 23:03:15 2023 +0200 add custom transliterator support commit 67d0775 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:39:48 2023 +0200 reuse work when checking for encoded chars commit 7a14dd6 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:18:47 2023 +0200 add replacement size hints commit 7e7cb4d Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:00:41 2023 +0200 fix safety violations with cursor offset commit 3b60b3f Author: Niels Saurer <[email protected]> Date: Sat Aug 26 21:20:32 2023 +0200 no unnecessary allocations commit 70275a3 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 18:12:29 2023 +0200 refactor set_ignore_len into constructor commit 3f818f5 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:54:49 2023 +0200 switch from raw_cursor to visible_content-relative cursor commit 9ff0945 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:43:23 2023 +0200 typo commit 2809374 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:42:14 2023 +0200 fmt commit 035cb9f Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:41:54 2023 +0200 add empty match test commit b289160 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:31:28 2023 +0200 fix run generation commit 2b90c2c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:12:02 2023 +0200 fix rule replacement application commit 9fcfffe Author: Niels Saurer <[email protected]> Date: Sat Aug 26 15:01:26 2023 +0200 fix cursor placeholder filter interaction commit 5d8f97e Merge: d820a5c bddf819 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:06:47 2023 +0200 Merge branch 'main' into tl-runtime commit d820a5c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:05:40 2023 +0200 regenerate testdata commit 9abee53 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:04:42 2023 +0200 useless assert commit 7bafbe6 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:02:09 2023 +0200 fmt commit 9f29e9c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:59:31 2023 +0200 add ignore_len to replaceable and therefore make function calls work commit 57b2e1a Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:31:08 2023 +0200 setup for function call replacement commit d384afc Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:14:12 2023 +0200 add function call + Any-Remove test commit 2e80fa9 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:03:59 2023 +0200 make quantifiers work (including with segments) commit 2419524 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:42:50 2023 +0200 Squash of segments with indices commit b62edfe Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:30:56 2023 +0200 regenerate test+bakeddata commit ba7a333 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:23:33 2023 +0200 add idx to segments commit bddf819 Author: Robert Bastian <[email protected]> Date: Fri Aug 25 21:45:28 2023 +0200 pen Cleaning up the workspace (unicode-org#3938) commit beae962 Author: Shane F. Carr <[email protected]> Date: Fri Aug 25 12:22:25 2023 -0700 Add some scripts and regions to HelloWorldProvider (unicode-org#3936) commit 0006bb9 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:09:31 2023 +0200 quantifiers, but broken because of dynamic segment numbering commit 5097871 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 01:37:09 2023 +0200 support segments + backrefs commit 6e8eed1 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 01:07:36 2023 +0200 switch to input str wrapper for anchor support commit e11279a Author: Niels Saurer <[email protected]> Date: Sat Aug 26 00:03:41 2023 +0200 wip commit 15397da Author: Niels Saurer <[email protected]> Date: Fri Aug 25 23:21:28 2023 +0200 more commit 7713ec6 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 21:04:26 2023 +0200 test in bakeddata commit 8b52bc2 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 20:27:19 2023 +0200 add test transform rules commit cc8532a Author: Niels Saurer <[email protected]> Date: Fri Aug 25 20:19:34 2023 +0200 simple things are working :) commit 60ce069 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:18:36 2023 +0200 wip commit be4359b Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:08:07 2023 +0200 fmt commit 9976099 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:08:02 2023 +0200 wip commit 59ddc1f Merge: 0a86ca8 0d9ce4b Author: Niels Saurer <[email protected]> Date: Fri Aug 25 15:31:40 2023 +0200 Merge branch 'main' into tl-runtime commit 0a86ca8 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 15:31:21 2023 +0200 wip commit 8c79370 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 02:49:58 2023 +0200 wip commit e0dcb85 Author: Niels Saurer <[email protected]> Date: Thu Aug 24 23:27:00 2023 +0200 wip
commit 595fd38 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 15:17:34 2023 +0000 more notes commit 7e08042 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 15:03:39 2023 +0000 trait docs commit 8dff4d9 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:53:23 2023 +0000 more comments commit 6286c28 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:48:32 2023 +0000 regenerate testdata commit 5ba561d Merge: f942dfb ad8e54b Author: Niels Saurer <[email protected]> Date: Mon Aug 28 14:46:49 2023 +0000 Merge branch 'main' into tl-runtime commit f942dfb Author: Niels Saurer <[email protected]> Date: Mon Aug 28 13:57:29 2023 +0000 more docs for replaceable.rs commit cf82d85 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 12:38:25 2023 +0000 remove last unsafe in transliterator module commit 74e1e8f Author: Niels Saurer <[email protected]> Date: Mon Aug 28 05:07:08 2023 +0200 doc changes commit c5f521b Author: Niels Saurer <[email protected]> Date: Mon Aug 28 04:21:21 2023 +0200 factor out partially-invisible-vec semantics into Hide commit c33bc8d Author: Niels Saurer <[email protected]> Date: Mon Aug 28 03:16:44 2023 +0200 replaceable api changes commit 3932436 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 03:10:25 2023 +0200 safe replaceable-from-insertable getting commit 0ef369f Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:27:53 2023 +0200 fix backref bug commit 7822602 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:21:36 2023 +0200 improve perf by '25%' commit c88e2f4 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:18:37 2023 +0200 remove duplicate license header commit 88d037d Author: Niels Saurer <[email protected]> Date: Mon Aug 28 01:09:38 2023 +0200 avoid potential cursor safety issue commit ba16b35 Author: Niels Saurer <[email protected]> Date: Mon Aug 28 00:38:40 2023 +0200 enforce no key matching after post matching commit 5370bc2 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 22:44:34 2023 +0200 remove eprintlns commit 7d1fb9e Author: Niels Saurer <[email protected]> Date: Sun Aug 27 22:34:57 2023 +0200 benchmarking commit 5e0e3b2 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 21:57:10 2023 +0200 refactor RepMatcher to avoid some index recomputations commit cd7091d Author: Niels Saurer <[email protected]> Date: Sun Aug 27 21:25:46 2023 +0200 switch to safer Matcher API commit 283ba60 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 15:52:03 2023 +0200 notes commit 3ccc422 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 14:46:58 2023 +0200 cursoroffset::byte safety commit d1f880d Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:28:50 2023 +0200 cleanup commit 2255447 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:21:28 2023 +0200 cleanup commit a03f2f8 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:14:30 2023 +0200 add convenience function commit 41b1fd0 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 03:06:04 2023 +0200 add notes commit a270ce5 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 02:42:33 2023 +0200 300k lines is maybe a bit much commit fe5ed45 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 02:35:46 2023 +0200 add cldr testData tests for supported locales commit 2c12542 Author: Niels Saurer <[email protected]> Date: Sun Aug 27 01:17:09 2023 +0200 use other crates' baked providers commit 2b3d91e Author: Niels Saurer <[email protected]> Date: Sun Aug 27 01:03:33 2023 +0200 make normalization tests pass, but baked is probably wrong commit 437443b Author: Niels Saurer <[email protected]> Date: Sun Aug 27 00:16:07 2023 +0200 add notes commit 66be38b Author: Niels Saurer <[email protected]> Date: Sat Aug 26 23:03:15 2023 +0200 add custom transliterator support commit 67d0775 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:39:48 2023 +0200 reuse work when checking for encoded chars commit 7a14dd6 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:18:47 2023 +0200 add replacement size hints commit 7e7cb4d Author: Niels Saurer <[email protected]> Date: Sat Aug 26 22:00:41 2023 +0200 fix safety violations with cursor offset commit 3b60b3f Author: Niels Saurer <[email protected]> Date: Sat Aug 26 21:20:32 2023 +0200 no unnecessary allocations commit 70275a3 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 18:12:29 2023 +0200 refactor set_ignore_len into constructor commit 3f818f5 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:54:49 2023 +0200 switch from raw_cursor to visible_content-relative cursor commit 9ff0945 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:43:23 2023 +0200 typo commit 2809374 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:42:14 2023 +0200 fmt commit 035cb9f Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:41:54 2023 +0200 add empty match test commit b289160 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:31:28 2023 +0200 fix run generation commit 2b90c2c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 17:12:02 2023 +0200 fix rule replacement application commit 9fcfffe Author: Niels Saurer <[email protected]> Date: Sat Aug 26 15:01:26 2023 +0200 fix cursor placeholder filter interaction commit 5d8f97e Merge: d820a5c bddf819 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:06:47 2023 +0200 Merge branch 'main' into tl-runtime commit d820a5c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:05:40 2023 +0200 regenerate testdata commit 9abee53 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:04:42 2023 +0200 useless assert commit 7bafbe6 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 04:02:09 2023 +0200 fmt commit 9f29e9c Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:59:31 2023 +0200 add ignore_len to replaceable and therefore make function calls work commit 57b2e1a Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:31:08 2023 +0200 setup for function call replacement commit d384afc Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:14:12 2023 +0200 add function call + Any-Remove test commit 2e80fa9 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 03:03:59 2023 +0200 make quantifiers work (including with segments) commit 2419524 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:42:50 2023 +0200 Squash of segments with indices commit b62edfe Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:30:56 2023 +0200 regenerate test+bakeddata commit ba7a333 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:23:33 2023 +0200 add idx to segments commit bddf819 Author: Robert Bastian <[email protected]> Date: Fri Aug 25 21:45:28 2023 +0200 pen Cleaning up the workspace (unicode-org#3938) commit beae962 Author: Shane F. Carr <[email protected]> Date: Fri Aug 25 12:22:25 2023 -0700 Add some scripts and regions to HelloWorldProvider (unicode-org#3936) commit 0006bb9 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 02:09:31 2023 +0200 quantifiers, but broken because of dynamic segment numbering commit 5097871 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 01:37:09 2023 +0200 support segments + backrefs commit 6e8eed1 Author: Niels Saurer <[email protected]> Date: Sat Aug 26 01:07:36 2023 +0200 switch to input str wrapper for anchor support commit e11279a Author: Niels Saurer <[email protected]> Date: Sat Aug 26 00:03:41 2023 +0200 wip commit 15397da Author: Niels Saurer <[email protected]> Date: Fri Aug 25 23:21:28 2023 +0200 more commit 7713ec6 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 21:04:26 2023 +0200 test in bakeddata commit 8b52bc2 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 20:27:19 2023 +0200 add test transform rules commit cc8532a Author: Niels Saurer <[email protected]> Date: Fri Aug 25 20:19:34 2023 +0200 simple things are working :) commit 60ce069 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:18:36 2023 +0200 wip commit be4359b Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:08:07 2023 +0200 fmt commit 9976099 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 19:08:02 2023 +0200 wip commit 59ddc1f Merge: 0a86ca8 0d9ce4b Author: Niels Saurer <[email protected]> Date: Fri Aug 25 15:31:40 2023 +0200 Merge branch 'main' into tl-runtime commit 0a86ca8 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 15:31:21 2023 +0200 wip commit 8c79370 Author: Niels Saurer <[email protected]> Date: Fri Aug 25 02:49:58 2023 +0200 wip commit e0dcb85 Author: Niels Saurer <[email protected]> Date: Thu Aug 24 23:27:00 2023 +0200 wip
Thanks @nciric for the contribution!
(I need this for making an interesting example in #3928)