Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround ICU not supporting git yet #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

workaround ICU not supporting git yet #8

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 29, 2018

Fixes: #7

I verified that this is able to create a near-identical icu4c 62.1 package. Differences are:

  • .gitignore was moved to the top level
  • the bomlist file has contents in a different order (due to svn)

with this PR, make dist produces:

icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-sdoc.tgz
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-data-62_1-r4a3ba8e.zip
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-docs-62_1-r4a3ba8e.zip
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-src-62_1-r4a3ba8e.tgz
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-src-62_1-r4a3ba8e.zip
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Fedora-28.tgz
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Fedora-28.tgz.md5
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Ubuntu-18.04.tgz
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Ubuntu-18.04.tgz.md5

… where the git hash unicode-org/icu@4a3ba8e refers to the tag https://github.com/unicode-org/icu/releases/tag/release-62-1

@srl295 srl295 added the enhancement New feature or request label Sep 29, 2018
@srl295 srl295 self-assigned this Sep 29, 2018
@srl295 srl295 requested review from sffc and yumaoka September 29, 2018 02:33
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2018

CLA assistant check
All committers have signed the CLA.

@srl295
Copy link
Member Author

srl295 commented Mar 1, 2019

@roubert is this superseded by #9 and #10 ?

@srl295 srl295 requested a review from roubert March 1, 2019 16:45
@roubert
Copy link
Member

roubert commented Mar 1, 2019

@roubert is this superseded by #9 and #10 ?

The change to Makefile is now obsolete but the other changes replacing svnversion are still relevant.

- need to verify the output against existing releases

Fixes: #7
@srl295 srl295 mentioned this pull request Apr 10, 2019
Base automatically changed from master to main March 24, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants