Update characterization for plural_rules, datetime skeletons, and other small changes #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-oly
changed the title
|
This will help us better understand the types of failures, e.g., compact and floating point values fail in almost all plural_rules tests. |
|
PTAL. |
echeran
reviewed
Nov 14, 2024
…characterize_plural_fails
…characterize_plural_fails
…characterize_plural_fails
…characterize_plural_fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For plural_rules, now check for sample type including integer, float, exponential, and compact.
For datetime_fmt, collect skeleton info.
For locale_display_names, characterize () --> [] and the reverse.