Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart native to config #236

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Jun 5, 2024

No description provided.

Copy link
Collaborator

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work, Moritz!

@sven-oly
Copy link
Collaborator

What's required for moving forward with this? I'm pleased that you're working on it!

run_config.json Outdated Show resolved Hide resolved
@mosuem mosuem marked this pull request as ready for review June 21, 2024 12:04
@mosuem
Copy link
Contributor Author

mosuem commented Jun 21, 2024

What's required for moving forward with this?

I think this should be ready to merge, but the CI started failing for some mysterious reason... I am looking into it.

@sven-oly
Copy link
Collaborator

Hi Moritz. Have you had a chance to investigate this. It would be great to have Dart Native back in the dashboard!

@sven-oly
Copy link
Collaborator

I've tried this CL but am getting this error. What needs to be done?

"~/ICU_conformance/conformance/executors/dart ~/ICU_conformance/conformance
Resolving dependencies... (1.1s)
The current Dart SDK version is 3.0.7.

Because dart_executor depends on lints >=4.0.0 which requires SDK version ^3.1.0, version solving failed.
"

@sven-oly
Copy link
Collaborator

I installed a newer version of Dart, v3.4.4, but am now getting this:
"~/ICU_conformance/conformance
DART NATIVE COMPILE
~/ICU_conformance/conformance/executors/dart ~/ICU_conformance/conformance
Resolving dependencies...
Downloading packages...
_fe_analyzer_shared 67.0.0 (73.0.0 available)
analyzer 6.4.1 (6.8.0 available)
native_assets_cli 0.6.1 (0.7.2 available)
Got dependencies!
3 packages have newer versions incompatible with dependency constraints.
Try dart pub outdated for more information.
Package(s) intl4x require the native assets feature to be enabled. Enable native assets with --enable-experiment=native-assets.
"
Here's the version I'm using now:

ccornelius@ccornelius3:~/ICU_conformance/conformance$ dart --version
Dart SDK version: 3.4.4 (stable) (Wed Jun 12 15:54:31 2024 +0000) on "linux_x64"

@mosuem
Copy link
Contributor Author

mosuem commented Jul 19, 2024

Thanks for investigating, I added the experimental flag. It now fails with a call to the CDN, which we are in the process of switching. As soon as dart-lang/native#987 lands, I will revisit this!

@sven-oly
Copy link
Collaborator

Hi Moritz! Is this PR ready to go? I'd be pleased to have this be part of the Conformance site.

@mosuem
Copy link
Contributor Author

mosuem commented Aug 20, 2024

Hi Moritz! Is this PR ready to go? I'd be pleased to have this be part of the Conformance site.

Working on it, thanks for the reminder!

@sven-oly
Copy link
Collaborator

sven-oly commented Nov 5, 2024

Hey Moritz, is this still something we should work on? I'd be happy to have dart native included. What needs to be done? Can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants