Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18108 Give all languages a primary script: trivial cases #4210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

conradarcturus
Copy link
Contributor

This change adds "primary" scripts to many languages in language_script.tsv.

This won't change likely subtags, rather this just future-proofs our data by recognizing a singular primary script, avoiding issues where ambiguities served customers the wrong script.

I also added scripts for languages in country_language_population.tsv that were missing.

CLDR-18108

  • This PR completes the ticket.

There are many more tasks, especially more complicated ones, in the parent ticket https://unicode-org.atlassian.net/browse/CLDR-18102

ALLOW_MANY_COMMITS=true

1. Every language needs at least 1 script considered the **primary** script.
1. This data is used to determine [the most Likely language and region](likelysubtags-and-default-content) so there needs to be at least 1 primary value.
2. [Changed in v47] Include a primary script for historical languages (eg. Ancient Greek, Coptic). The primary script should reflect where the majority of the written corpus originates from.
2. Languages written by significant populations with different scritps in different countries can have multiple **primary** scripts. The [likely subtags](https://www.unicode.org/cldr/charts/latest/supplemental/likely_subtags.html) patterns will use population counts to disambiguate the default script for each locale.
Copy link
Member

@macchiati macchiati Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this; I think it complicates our work. It is simplest if there is exactly 1 primary script, period, that will match the maximized value for the language. All others are not needed, because they will be derived from language population data. Eg if Kurdish has Latin as the primary script, but ku_Arab is the largest population (of ku*) speakers, then we will generate ku_IQ => ku_Arab_IQ in likely subtags.

Is there any other purpose to having any additional primaries or secondaries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that to (only ever 1 primary). Do you think the CLDR TC agrees with that? I don't think I had much involvement.

I was trying to strike a compromise with the concerns people had about picking a primary language (that was mentioned in the DDL group). I'll bring it up again in the next DDL meeting.

@@ -1712,6 +1717,7 @@ XXX Code for transations where no currency is involved
<language type="ilo" territories="PH" alt="secondary"/>
<language type="inh" scripts="Cyrl"/>
<language type="inh" scripts="Arab Latn" territories="RU" alt="secondary"/>
<language type="io" scripts="Latn" alt="secondary"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secondary with no primary, see comment below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for other new secondaries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto-generated. TBH I don't understand why the ConvertLanguageData script did this for this entry but not others -- I suspect because its missing territory data. I'll have to edit ConvertLanguageData.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the script so it will no longer demote historical scripts/historical languages.

@macchiati
Copy link
Member

macchiati commented Nov 21, 2024 via email

This change adds "primary" scripts to many languages in language_script.tsv.

This won't change likely subtags, rather this just future-proofs our data by recognizing a singular primary script, avoiding issues where ambiguities served customers the wrong script.

I also added scripts for languages in country_language_population.tsv that were missing.
Updated the ConvertLanguageData script to avoid demoting historical scripts/historical langauges.

Also removed multi-primary script notes from the description -- anticipating a re-design, handled by other tasks.
@conradarcturus conradarcturus force-pushed the conradarcturus/CLDR-18108-add-primary-scripts branch from 3cb6b86 to 7f653f7 Compare November 21, 2024 21:33
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/supplemental/supplementalData.xml is different
  • docs/site/development/updating-codes/update-language-script-info/language-script-description.md is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/tool/ConvertLanguageData.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

mvn spotless:apply
@macchiati
Copy link
Member

I think we should put this on hold for now, and focus on https://unicode-org.atlassian.net/browse/CLDR-18087.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants