Hotfix: Don't request urls every time the document name updates #17710
+85
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
Screen.Recording.2024-12-03.at.11.35.30.mov
This PR fixes an issue with the document URL UI updating every time the document name is changed. The main problem was that the observer responsible for requesting the URLs also included the document variant names. This resulted in a server request being made every time the name was changed.
I have split the observer into two: one for loading the document URLs and one for observing the variants.
The PR also includes general event cleanup and adds a loader state.
what to test