1.24 Prevent crash with blank editor · udacity/ud845-Pets@6a82f79

Why do we check if the mCurrentPetUri is null? Should't we check if we have input for everything regardless if we are in the save a pet or update a pet mode? Because user can accidentally delete an input in update pet mode and press save pet.

This is the first time I came into solution code to see why this (uri == null) check is here.

Why do we check if the mCurrentPetUri is null? it doesn't seem to make any difference to the intended functionality

We shouldn't check for mCurrentPetUri being null , as if it's not null and we try to modify an existing pet , we would get another crash for example if we delete all the property and saved it.

Is there a meaningful difference between TextUtils.isEmpty(nameString) and nameString.isEmpty()?

Additionally, I used or operators here because if any field is empty, the save should be rejected:
if (weightString.isEmpty() || nameString.isEmpty() || breedString.isEmpty()) { Toast.makeText(this, "Cannot save without name, breed, and weight.", Toast.LENGTH_SHORT).show(); return; }

Yes, TextUtils.isEmpty is preferred. Take a look here
https://stackoverflow.com/questions/36388581/android-textutils-isempty-vs-string-isempty/36388600

@kwhitejr

why do we use && operator for comparison and not || ? since just like @kwhitejr said; we want to reject the app from saving the data if the any input field is empty?

why is the weight also been checked since we have already assigned a default value to it?
if its going to be validated here why dont we just remove the default value ?

This whole if statement is wrong and useless. It doesn't prevent the user to update the pet with empty values. The name was supposed to be NOT NULL.

Use || instead of && and it will work, this way you check for each value

if (mCurrentPetUri == null || TextUtils.isEmpty(nameString) || TextUtils.isEmpty(breedString)
                || TextUtils.isEmpty(weightString) || mGender == PetEntry.GENDER_UNKNOWN) {
            return;
        }

The whole statement is incorrect and some value are unnecessary.
first we shouldn't check for uri being null as we'll be free to input blank value in the edit pet.
Second we shouldn't also include UNKNOWN as a check as people can still insert it as a valid option and i'll be rejected.
And finally We don't have to check for the weight as it get a default value of 0 below
So the final code for checking should look like this.

if (TextUtils.isEmpty(nameString) || TextUtils.isEmpty(breedString)){ return; }

weight is already defined
so make int weight1

    // If the weight is not provided by the user, don't try to parse the string into an
    // integer value. Use 0 by default.
    values.put(PetEntry.COLUMN_PET_WEIGHT, TextUtils.isEmpty(weightString) ? 0 : Integer.parseInt(weightString));

mgillieron · 2017-03-31T15:37:15Z

For me the code for checking is a bit strange.
What is happening if the user add a pet leaving only the blank name ?
This pet is saved in the database whereas it has been specified that the "Name" column cannot be NULL.

What do you think about that ?
Thanks.

oleohi · 2017-04-05T12:44:25Z

Good question. I was thinking about that too. In that case, we might need to check for name specifically to ensure the user inputs something.

mgillieron · 2017-04-05T15:04:35Z

Yes I think so, thanks oleohi !

my-jabin · 2017-04-20T11:03:50Z

Should we check the name and breed only in the EditorActivity, when we call the savePet() method?
If there are 10 EditText, how could we check them all?

oleohi · 2017-04-20T19:34:25Z

Yes. Since they are the compulsory or mandatory fields, I think you would have to check for all of them. You can use an if-else statement with logical operators.

PackHg · 2017-05-03T12:38:06Z

An empty String is not NULL, isn't it?

mgillieron · 2017-05-03T13:49:27Z

Absolutely ! NULL and empty are 2 different things. Moreover, the "TextUtils" class has a method called "isEmpty" verifying if a string is null OR empty (here empty means that the string has a length of 0)

andresual · 2017-05-17T20:44:11Z

I was skipped the sanity check video. Isn't work yet

namclu · 2017-06-02T04:00:14Z

I feel as if the code needs a nested if-else statement to check for the possibility that each field could be left blank, though only the name field really matters

linucksrox · 2017-06-02T19:50:39Z

@namclu You're right! I'm not sure which part of the lesson you're on, but they go over "Sanity Checking" in section 3.17. Eventually the sanity checking happens in the ContentProvider which acts like a "gatekeeper" between the data and the application accessing it. It's better to do checking there because in the case where multiple different activities might be inputting data, you can avoid having to write the error checking code in all of those places.

namclu · 2017-06-03T02:12:54Z

@linucksrox yes I thought this would be best handled in a centralized location, specifically as you mentioned in the PetProvider. Right now, the code seems a bit ad-hoc in that we do data checks at the points when we need to, but maybe in order to have PetProvider (or another class) manage all that would make the code more unwieldy

ankurg22 · 2017-08-12T12:49:21Z

Here is my solution.

String name = mNameEditText.getText().toString().trim();
        String breed = mBreedEditText.getText().toString().trim();
        String weightString = mWeightEditText.getText().toString().trim();
        int weight;
        try {
            weight = Integer.parseInt(weightString);
        } catch (NumberFormatException e) {
            weight = 0;
        }
        int gender = mGender;
        if (currentUri == null && TextUtils.isEmpty(name) || TextUtils.isEmpty(breed) || gender == PetEntry.GENDER_UNKNOWN) {
            return;
        }

Daggertho · 2017-09-01T14:14:16Z

I still don't know why do we implement "Sanity check" yet even after putting it in our functions after following every lesson. I know it is used for making that "gate" but it didn't show up any messages except, well in my case, my app crashed and was sent to the activity_catalog.xml if I didn't put any name or breed or weight... I thought it was supposed to show some messages.... if I used the logic as @ankurg22 made then what was the use of that sanity check?

romeyng · 2017-11-14T21:48:29Z

My app crashes whenever i use the fab to enter the editor activity. Clicking an item from the existing list lets me edit successfully. It turns out that mCurrentPetUri is causing the error because it is null in the return statement of onCreate loader. Any help greatly appreciated. Thank you!

public Loader onCreateLoader(int i, Bundle bundle) {
Log.v("Editor", "loader manager called");
String[] projection = {PetEntry._ID,
PetEntry.COLUMN_PET_NAME,
PetEntry.COLUMN_PET_BREED,
PetEntry.COLUMN_PET_GENDER,
PetEntry.COLUMN_PET_WEIGHT};
Log.v("Editor", "mcurrentPetUri: "+mCurrentPetUri);

    return new CursorLoader(this, mCurrentPetUri,projection,null,null,null);
}

n-abdelmaksoud · 2017-11-21T09:12:20Z

we have only two values not to be null in the CREATE TABLE statement: name and gender.
So we should save pet regardless breed is null or empty String and i think we should show Toast msg if the name field is empty or null.
and if name String is not empty, we should save the pet with setting default values for gender and weight.
That's my code, it works fine

 int defaultWeight=0;
        String name = mNameEditText.getText().toString().trim();
        String breed = mBreedEditText.getText().toString().trim();
        String weight = mWeightEditText.getText().toString().trim();

        if (TextUtils.isEmpty(name)) {
            Toast.makeText(this, getString(R.string.insert_pet_name_toast), Toast.LENGTH_LONG).show();
        } else {
            ContentValues values = new ContentValues();
            values.put(PetsContract.NAME, name);
            values.put(PetsContract.BREED, breed);
            values.put(PetsContract.GENDER, mGender);
            if(TextUtils.isEmpty(weight)){
                values.put(PetsContract.WEIGHT,defaultWeight);
            } else {
                values.put(PetsContract.WEIGHT, Integer.parseInt(weight));
            }

mGender is declared as a global variable and initialized:
private int mGender = 0;
it also takes a new value from the spinner selection

pooriant · 2017-12-28T08:37:48Z

i think we don't need to check all parameters before saving becuse at DbHelper class we set NOTNULL for 3 parameter Name,Weight,Gender
also we set a deafult value for Weight =0 there !!!

so we just need to check 2 or 1 parameter (Name,Gender) ,
if we don't want to save pet with Gender=Unknown we must use (OR then AND) because if either of Name or Gender will be empty we must return and don't save anything.
but if gender value doesn't matter ,we just need to check Name value doesn't have null
and if name has a value we can save pet to database

this is my solution

if(uri==null&&TextUtils.isEmpty(mNameEditText.getText())||mGender==PetEntry.GENDER_UNKNOWN){Toast.makeText(this, "Nothing Saved", Toast.LENGTH_SHORT).show(); return;}

nick-running · 2018-01-12T07:33:09Z

I use this code to parse weight int weight = Integer.parseInt(TextUtils.isEmpty(weightString)?"0":weightString);

parasarorahere · 2018-01-12T08:04:00Z

why we can't do in petProvider

isthiswrite · 2018-02-13T23:53:32Z

I don't agree with TextUtils.isEmpty for name, weight, breed, and gender. I only used it for name. The reason is if a user selects the dropdown spinner "male" for example, it will save a blank pet in the catalog activity leaving empty field. This is how I fixed that issue.

`private void savePet() {

    String nameString = mNameEditText.getText().toString().trim();
    String breedString = mBreedEditText.getText().toString().trim();
    String weightString = mWeightEditText.getText().toString().trim();

    // If the mCurrentPetUri null then create a new pet
   // No need to worry about Gender, as it will say Unknown by default, and if a name is not input
  // That would be the only scenario that would give error, pet not saved. So, if someone just chooses               //spinner or just adds weight, it won't matter because of if statements for breed and weight below

    if (mCurrentPetUri == null &&
            TextUtils.isEmpty(nameString)) {
        Toast.makeText(this, getString(R.string.pet_not_saved), Toast.LENGTH_SHORT).show();
        return;
    }

    // Create ContentValues object
    ContentValues values = new ContentValues();
    values.put(PetEntry.COLUMN_PET_NAME, nameString);
    values.put(PetEntry.COLUMN_PET_GENDER, mGender);

    // Breed String can be null, so when it is, make it say "Unknown Breed" or something
   
     
   String breed = "Unknown Breed";
    if (!TextUtils.isEmpty(breedString)){
      breed = breedString;
    }
    values.put(PetEntry.COLUMN_PET_BREED, breed);

  // Same thing with weight as breed 
   int weight = 0;
    if (!TextUtils.isEmpty(weightString)) {
        weight = Integer.parseInt(weightString);
    }
    values.put(PetEntry.COLUMN_PET_WEIGHT, weight);

`

Babadzhanov · 2018-06-05T14:55:25Z

This is not great way of handling errors..

Hendhussein · 2018-08-15T09:11:38Z

I am still having cruch when I insert new pet with name only or any item (not completed data) it dosnt show the toast message and close this is the code I dont know where is the problem

`private void savePet() {
// Read from input fields
// Use trim to eliminate leading or trailing white space
String nameString = mNameEditText.getText().toString().trim();
String breedString = mBreedEditText.getText().toString().trim();
String weightString = mWeightEditText.getText().toString().trim();

    // Check if this is supposed to be a new pet
    // and check if all the fields in the editor are blank
    if (mCurrentPetUri == null &&
            TextUtils.isEmpty(nameString) && TextUtils.isEmpty(breedString) &&
            // Since no fields were modified, we can return early without creating a new pet.
            // No need to create ContentValues and no need to do any ContentProvider operations.
            TextUtils.isEmpty(weightString) && mGender == PetEntry.GENDER_UNKNOWN) {return;}

    // Create a ContentValues object where column names are the keys,
    // and pet attributes from the editor are the values.
    ContentValues values = new ContentValues();
    values.put(PetEntry.COLUMN_PET_NAME, nameString);
    values.put(PetEntry.COLUMN_PET__BREED, breedString);
    values.put(PetEntry.COLUMN_PET__GENDER, mGender);
    // If the weight is not provided by the user, don't try to parse the string into an
    // integer value. Use 0 by default.
    int weight = 0;
    if (!TextUtils.isEmpty(weightString)) {
        weight = Integer.parseInt(weightString);
    }
    values.put(PetEntry.COLUMN_PET__WEIGHT, weight);

            // Determine if this is a new or existing pet by checking if mCurrentPetUri is null or not
    if (mCurrentPetUri == null) {
        // This is a NEW pet, so insert a new pet into the provider,
        // returning the content URI for the new pet.
        Uri newUri = getContentResolver().insert(PetEntry.CONTENT_URI, values);
        // Show a toast message depending on whether or not the insertion was successful.
        if (newUri == null) {
            // If the new content URI is null, then there was an error with insertion.
            Toast.makeText(this, getString(R.string.editor_insert_pet_failed),
                    Toast.LENGTH_SHORT).show();
        } else {
            // Otherwise, the insertion was successful and we can display a toast.
            Toast.makeText(this, getString(R.string.editor_insert_pet_successful),
                    Toast.LENGTH_SHORT).show();
        }
    }
    // Otherwise this is an EXISTING pet, so update the pet with content URI: mCurrentPetUri
    // and pass in the new ContentValues. Pass in null for the selection and selection args
    // because mCurrentPetUri will already identify the correct row in the database that
    // we want to modify.
    int rowsAffected = getContentResolver().update(mCurrentPetUri, values, null, null);
    // Show a toast message depending on whether or not the update was successful.
    if (rowsAffected == 0) {
        // If no rows were affected, then there was an error with the update.
        Toast.makeText(this, getString(R.string.editor_update_pet_failed),
                Toast.LENGTH_SHORT).show();
    } else {
        // Otherwise, the update was successful and we can display a toast.
        Toast.makeText(this, getString(R.string.editor_update_pet_successful),
                Toast.LENGTH_SHORT).show();
    }

}

aydinaytac · 2018-08-24T14:44:25Z

In this case user can't add a pet without name, but after addind a pet, in edit mode user can save without name! This is useless...

xht418 · 2018-11-14T22:23:52Z

I. Method "value.put(columnName, value)" won't let "NULL" situation happen to the SQLite database, no matter you set "NOT NULL" or not for the column in your sql create statement of your table in the dbHelper class.

II. EditText has its own default value for each "inputType", for example "0" for the "number" type, empty String "" for the "text" or other text type. Besides that, "getText()" will never return null value, it will return its default value for specific "inputType", which means empty String "" and number "0" will be "put" into the table if you don't enter anything. At this point, think about I.

III. Based on the above, we better handle user input in the right inside the "action_save" action menu button.

Please point out if anything is wrong.

Ivoiran2014 · 2020-08-15T11:48:33Z

The whole checking statement is incorrect and some value are unnecessary.
first we shouldn't check for uri being null ,as if we did ,we'll be free to input blank value into an existing pet.
Second we shouldn't also include UNKNOWN as a check as UNKNOW is a valid option and some could update MALE to UNKNOW.
And finally We don't have to check for the weight as it get a default value of 0 below
So the final code for checking should look like this.

if (TextUtils.isEmpty(nameString) || TextUtils.isEmpty(breedString)){ return; }
int petWeight = 0;
if (!TextUtils.isEmpty(stringWeight)) { petWeight = Integer.parseInt(textWeight); }

JoaoCGualb · 2020-11-04T15:53:16Z

Alterei o codigo do if para
if (mCurrentPetUri == null &&
TextUtils.isEmpty(breedString) &&
TextUtils.isEmpty(weightString) && mGender == PetEntry.GENDER_UNKNOWN || TextUtils.isEmpty(nameString))
e funcionou ele da erro e não salva quando o nome esta em branco

Commit

There are no files selected for viewing

This comment has been minimized.

SzasznikaJanos Apr 7, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kwhitejr Nov 15, 2017 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

25 comments on commit 6a82f79

mgillieron commented on 6a82f79 Mar 31, 2017

Choose a reason for hiding this comment

oleohi commented on 6a82f79 Apr 5, 2017

Choose a reason for hiding this comment

mgillieron commented on 6a82f79 Apr 5, 2017

Choose a reason for hiding this comment

my-jabin commented on 6a82f79 Apr 20, 2017

Choose a reason for hiding this comment

oleohi commented on 6a82f79 Apr 20, 2017

Choose a reason for hiding this comment

PackHg commented on 6a82f79 May 3, 2017

Choose a reason for hiding this comment

mgillieron commented on 6a82f79 May 3, 2017

Choose a reason for hiding this comment

andresual commented on 6a82f79 May 17, 2017

Choose a reason for hiding this comment

namclu commented on 6a82f79 Jun 2, 2017

Choose a reason for hiding this comment

linucksrox commented on 6a82f79 Jun 2, 2017

Choose a reason for hiding this comment

namclu commented on 6a82f79 Jun 3, 2017

Choose a reason for hiding this comment

ankurg22 commented on 6a82f79 Aug 12, 2017 • edited Loading

Choose a reason for hiding this comment

Daggertho commented on 6a82f79 Sep 1, 2017

Choose a reason for hiding this comment

romeyng commented on 6a82f79 Nov 14, 2017

Choose a reason for hiding this comment

n-abdelmaksoud commented on 6a82f79 Nov 21, 2017

Choose a reason for hiding this comment

pooriant commented on 6a82f79 Dec 28, 2017

Choose a reason for hiding this comment

nick-running commented on 6a82f79 Jan 12, 2018

Choose a reason for hiding this comment

parasarorahere commented on 6a82f79 Jan 12, 2018

Choose a reason for hiding this comment

isthiswrite commented on 6a82f79 Feb 13, 2018

Choose a reason for hiding this comment

Babadzhanov commented on 6a82f79 Jun 5, 2018

Choose a reason for hiding this comment

Hendhussein commented on 6a82f79 Aug 15, 2018 • edited Loading

Choose a reason for hiding this comment

aydinaytac commented on 6a82f79 Aug 24, 2018

Choose a reason for hiding this comment

xht418 commented on 6a82f79 Nov 14, 2018 • edited Loading

Choose a reason for hiding this comment

Ivoiran2014 commented on 6a82f79 Aug 15, 2020

Choose a reason for hiding this comment

JoaoCGualb commented on 6a82f79 Nov 4, 2020

Choose a reason for hiding this comment

SzasznikaJanos Apr 7, 2018 •

edited

Loading

kwhitejr Nov 15, 2017 •

edited

Loading

25 comments on commit `6a82f79`

mgillieron commented on `6a82f79` Mar 31, 2017

oleohi commented on `6a82f79` Apr 5, 2017

mgillieron commented on `6a82f79` Apr 5, 2017

my-jabin commented on `6a82f79` Apr 20, 2017

oleohi commented on `6a82f79` Apr 20, 2017

PackHg commented on `6a82f79` May 3, 2017

mgillieron commented on `6a82f79` May 3, 2017

andresual commented on `6a82f79` May 17, 2017

namclu commented on `6a82f79` Jun 2, 2017

linucksrox commented on `6a82f79` Jun 2, 2017

namclu commented on `6a82f79` Jun 3, 2017

ankurg22 commented on `6a82f79` Aug 12, 2017 •

edited

Loading

Daggertho commented on `6a82f79` Sep 1, 2017

romeyng commented on `6a82f79` Nov 14, 2017

n-abdelmaksoud commented on `6a82f79` Nov 21, 2017

pooriant commented on `6a82f79` Dec 28, 2017

nick-running commented on `6a82f79` Jan 12, 2018

parasarorahere commented on `6a82f79` Jan 12, 2018

isthiswrite commented on `6a82f79` Feb 13, 2018

Babadzhanov commented on `6a82f79` Jun 5, 2018

Hendhussein commented on `6a82f79` Aug 15, 2018 •

edited

Loading

aydinaytac commented on `6a82f79` Aug 24, 2018

xht418 commented on `6a82f79` Nov 14, 2018 •

edited

Loading

Ivoiran2014 commented on `6a82f79` Aug 15, 2020

JoaoCGualb commented on `6a82f79` Nov 4, 2020