-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiManagerParameter Checkboxes and Radios #1775
base: master
Are you sure you want to change the base?
Commits on Oct 30, 2024
-
Refactor parameter 'length' as 'maxLength'
This does *not* refer to the length of the string passed in, or the length of the string currently stored. This refers to the maximum length of the HTML form, and the size of the class buffer to hold the value. Note that this does *not* change the internal _length name, because the variable is exposed as protected and through friendship with WiFiManager. It is however marked deprecated and can be changed on the next major release.
Configuration menu - View commit details
-
Copy full SHA for 0df7c77 - Browse repository at this point
Copy the full SHA 0df7c77View commit details -
Change param value length function name
To clarify that the function returns the *max* possible length, and not the length of the current value. Deprecating getValueLength for removal on next major release.
Configuration menu - View commit details
-
Copy full SHA for f75dd98 - Browse repository at this point
Copy the full SHA f75dd98View commit details -
In HTML forms names and IDs are two different things. Although this value is applied to both attributes, the form data corresponds to the name, *not* the ID. This causes confusion if we want the name and ID to differ, since we are currently calling the name the ID.
Configuration menu - View commit details
-
Copy full SHA for dd38239 - Browse repository at this point
Copy the full SHA dd38239View commit details -
Add setValueReceived function to params
For intercepting the value received from the server in derived classes
Configuration menu - View commit details
-
Copy full SHA for b002b03 - Browse repository at this point
Copy the full SHA b002b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for c781390 - Browse repository at this point
Copy the full SHA c781390View commit details -
Add negative check to param max length
Preventing a new default value from being assigned if the max length is set to a negative value
Configuration menu - View commit details
-
Copy full SHA for 2703370 - Browse repository at this point
Copy the full SHA 2703370View commit details -
Because this is polymorphic, the destructor needs to be virtual to allow for properly clearing data
Configuration menu - View commit details
-
Copy full SHA for 246d521 - Browse repository at this point
Copy the full SHA 246d521View commit details -
Move param HTML generation to class
This creates better encapsulation, and allows it to be overridden by child classes.
Configuration menu - View commit details
-
Copy full SHA for 944589c - Browse repository at this point
Copy the full SHA 944589cView commit details -
Remove param token "I" processing
This is unused and awkward because it must be done within the manager class to use the loop parameter, since passing the loop value to the parameter object would be odd. Removing it makes the most sense, although it is technically a breaking change if the user has custom string files.
Configuration menu - View commit details
-
Copy full SHA for c4665fc - Browse repository at this point
Copy the full SHA c4665fcView commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d7848f - Browse repository at this point
Copy the full SHA 5d7848fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e14c8d7 - Browse repository at this point
Copy the full SHA e14c8d7View commit details
Commits on Nov 19, 2024
-
Use class for parameter radio options
This makes it possible to declare options at the same time as the radio object, and provides for more flexibility.
Configuration menu - View commit details
-
Copy full SHA for 6f1a50a - Browse repository at this point
Copy the full SHA 6f1a50aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf64c3 - Browse repository at this point
Copy the full SHA aaf64c3View commit details