-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add writeStream #480
Add writeStream #480
Conversation
This still needs a test for |
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 96.23% 96.51% +0.27%
==========================================
Files 60 60
Lines 1036 1119 +83
Branches 7 8 +1
==========================================
+ Hits 997 1080 +83
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you for the help @etspaceman! The build I think is failing because of low coverage. It should get green as soon as we add the missing unit tests. I will try to look into the PR today else it may have to wait until after Christmas. |
No rush! I'll try to get that test in tonight. I'm not quite sure how I'll test it yet but I'll come up with something :D |
@imarios I was trying to add tests for |
@etspaceman looks great! I am running the tests one more time and merging. |
Solves #232 partially by adding
writeStream