added linear regression #332

JakubSroka · 2018-09-19T12:41:34Z

codecov-io · 2018-09-19T13:33:15Z

Codecov Report

Merging #332 into master will increase coverage by 1.37%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   94.95%   96.33%   +1.37%     
==========================================
  Files          55       57       +2     
  Lines         991     1009      +18     
  Branches       10       10              
==========================================
+ Hits          941      972      +31     
+ Misses         50       37      -13

Impacted Files	Coverage Δ
...a/frameless/ml/internals/LinearInputsChecker.scala	`100% <100%> (ø)`
...rameless/ml/regression/TypedLinearRegression.scala	`93.75% <93.75%> (ø)`
...main/scala/frameless/ops/RelationalGroupsOps.scala	`79.16% <0%> (-18.46%)`	⬇️
...la/frameless/functions/NonAggregateFunctions.scala	`100% <0%> (ø)`	⬆️
.../frameless/CatalystNumericWithJavaBigDecimal.scala	`100% <0%> (ø)`	⬆️
...aset/src/main/scala/frameless/ops/GroupByOps.scala	`98.36% <0%> (+31.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b974a...2775be3. Read the comment docs.

Gryfit · 2018-09-21T06:42:21Z

ml/src/main/scala/frameless/ml/regression/TypedLinearRegression.scala

+  def setEpsilon(value: Double):            TypedLinearRegression[Inputs] = copy(lr.setEpsilon(value))
+
+  private def copy(newRf: LinearRegression): TypedLinearRegression[Inputs] =
+    new TypedLinearRegression[Inputs](newRf, labelCol, featuresCol, weightCol)


changed to lr

Gryfit · 2018-09-21T06:43:30Z

ml/src/test/scala/frameless/ml/regression/TypedLinearRegressionTests.scala

+      pDs.select(pDs.col('a), pDs.col('b)).collect.run() == Seq(x2.a -> x2.b)
+    }
+    val prop2 = forAll { x2: X2[Vector, Double] =>
+      val rf = TypedLinearRegression[X2[Vector, Double]]


changed to lr

Gryfit · 2018-09-21T06:47:52Z

ml/src/test/scala/frameless/ml/regression/TypedLinearRegressionTests.scala

+    )
+
+    val ds2 = Seq(
+      X3(new DenseVector(Array(1.0)): Vector,2: Float, 1.0),


You can just use 2F instead of 2: Float

Avasil · 2018-09-21T06:50:36Z

ml/src/test/scala/frameless/ml/regression/TypedLinearRegressionTests.scala

+      model.transformer.getAggregationDepth == 10 &&
+        model.transformer.getElasticNetParam == 0.5 &&
+        model.transformer.getEpsilon == 4.0 &&
+        model.transformer.getFitIntercept == true &&


You could skip == true

Avasil · 2018-09-21T06:50:50Z

ml/src/test/scala/frameless/ml/regression/TypedLinearRegressionTests.scala

+        model.transformer.getLoss == lossStrategy.sparkValue &&
+        model.transformer.getMaxIter == 23 &&
+        model.transformer.getRegParam == 1.2 &&
+        model.transformer.getStandardization == true &&


as above, == true is redundant

Gryfit · 2018-09-21T06:51:47Z

ml/src/test/scala/frameless/ml/Generators.scala

+  implicit val arbLossStrategy: Arbitrary[LossStrategy] = Arbitrary {
+    Gen.oneOf(
+      Gen.const(LossStrategy.SquaredError),
+      Gen.const(LossStrategy.SquaredError)


LossStrategy.Huber

imarios · 2018-09-23T07:04:30Z

ml/src/main/scala/frameless/ml/regression/TypedLinearRegression.scala

@@ -0,0 +1,50 @@
+package frameless.ml.regression


package frameless package ml package regression

Same for all files

sure as you wish

OlivierBlanvillain · 2018-09-30T21:14:15Z

Thanks a lot for the PR! Merging 🎉

added linear regression

43e51ee

Gryfit reviewed Sep 21, 2018

View reviewed changes

Avasil reviewed Sep 21, 2018

View reviewed changes

Gryfit reviewed Sep 21, 2018

View reviewed changes

fixes

d03c5a8

JakubSroka force-pushed the linear_reg branch from 345d6cd to d03c5a8 Compare September 21, 2018 10:42

JakubSroka closed this Sep 21, 2018

JakubSroka reopened this Sep 21, 2018

Gryfit approved these changes Sep 21, 2018

View reviewed changes

imarios reviewed Sep 23, 2018

View reviewed changes

change package naming convention

2775be3

OlivierBlanvillain merged commit 542c0c8 into typelevel:master Sep 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added linear regression #332

added linear regression #332

JakubSroka commented Sep 19, 2018

codecov-io commented Sep 19, 2018 •

edited

Loading

Gryfit Sep 21, 2018

JakubSroka Sep 21, 2018

Gryfit Sep 21, 2018

JakubSroka Sep 21, 2018

Gryfit Sep 21, 2018

JakubSroka Sep 21, 2018

Avasil Sep 21, 2018

JakubSroka Sep 21, 2018

Avasil Sep 21, 2018

JakubSroka Sep 21, 2018

Gryfit Sep 21, 2018

JakubSroka Sep 21, 2018

imarios Sep 23, 2018

imarios Sep 23, 2018 •

edited

Loading

JakubSroka Sep 29, 2018

OlivierBlanvillain commented Sep 30, 2018

added linear regression #332

added linear regression #332

Conversation

JakubSroka commented Sep 19, 2018

codecov-io commented Sep 19, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imarios Sep 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlivierBlanvillain commented Sep 30, 2018

codecov-io commented Sep 19, 2018 •

edited

Loading

imarios Sep 23, 2018 •

edited

Loading