Skip to content

Commit

Permalink
The test target "finagle/finagle-core/src/test/scala:scala" is failin…
Browse files Browse the repository at this point in the history
…g too often in master in CI.

Summary:
Problem:

The test target "finagle/finagle-core/src/test/scala:scala" is failing too often in master in CI.

Logs available here:

Known to fail ticket: [CSL-12418](https://jira.twitter.biz/browse/CSL-12418)

Solution:

It has been marked "known-to-fail" in the BUILD file

Result:

This will cause it to be skipped in future builds, and its failures ignored in submit queue. This implies that code changes that further break this test will not be prevented from being submitted to the master branch, until the problem is fixed and the test is no longer marked known-to-fail.

Reviewers: O847 source:/finagle/finagle-core/!

Subscribers: O46742 source:/finagle/finagle-core/

JIRA Roadmap Project: <JIRA key, e.g. IOS-1234> If providing a value, remove everything except the JIRA key. Leave this field unchanged to complete later in the UI.

Change Classification: Select one of the following: roadmap-project, non-roadmap-project . You may also leave this field unmodified to complete later in the UI.

Differential Revision: https://phabricator.twitter.biz/D1170471

TBR=true
  • Loading branch information
Automated go/ktf Flagger authored and jenkins committed Sep 14, 2024
1 parent dc6680b commit aff1568
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion finagle-core/src/test/scala/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ junit_tests(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
# env_local is tag for bazel only, added due to DPB-14188
tags = ["bazel-compatible"],
tags = [
"bazel-compatible",
"known-to-fail-jira:CSL-12418",
],
dependencies = [
":pushsession-utils",
":stringprotocol",
Expand Down

0 comments on commit aff1568

Please sign in to comment.