-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMS-sketch #667
Open
cesarcolle
wants to merge
17
commits into
twitter:develop
Choose a base branch
from
cesarcolle:feature/AMS-Sketch
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
AMS-sketch #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcolle
force-pushed
the
feature/AMS-Sketch
branch
from
September 17, 2018 13:02
61c99f8
to
9027fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's it ?
related to #563
This is a monoid implementation for AMS sketch. Not all the optimization from Count Min Sketch algorithm are implemented, but it's a beginning and for some operation like innerProduct estimation, join, ..
What does it bring ?
I made some tests like join between two AMS / CMS :
and for CMS :
the delta / eps are translate to the proper buckets / depth for AMS / CMS.
I think with more optimisation we can have better score for AMS.
Better error estimation on inner-product
The estimation for innerProduct or F2 between AMS aren't properly implemented yet. I'll dig more in research paper to find probability, bounds, ...
BUT
I benchmark on something like :
I found this test always pass ans AMS create better estimation for the innerProduct.
How to use