Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Detect type of supported schemas when credentials are not found #574

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

talwinder50
Copy link
Member

@talwinder50 talwinder50 commented Aug 29, 2023

Edge case for when both type and schemas are missing will be addresses in #575

Signed-off-by: Talwinder kaur [email protected]

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2023
@talwinder50 talwinder50 changed the title feat(app): Support for schemas when credential not found feat(app): Detect type of supported schemas when credentials are not found Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b18a86) 90.01% compared to head (3f30355) 90.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          98       98           
  Lines        3907     3907           
=======================================
  Hits         3517     3517           
  Misses        258      258           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talwinder50 talwinder50 merged commit 6b51a9f into trustbloc:main Aug 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants