Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issuer profile controller, validators, and general error handling. #776

Merged
merged 1 commit into from
Sep 6, 2022
Merged

feat: issuer profile controller, validators, and general error handling. #776

merged 1 commit into from
Sep 6, 2022

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Sep 1, 2022

Signed-off-by: Volodymyr Kubiv [email protected]

@cla-bot cla-bot bot added the cla-signed label Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #776 (55b731b) into main (3389b6e) will increase coverage by 0.29%.
The diff coverage is 91.35%.

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   87.20%   87.50%   +0.29%     
==========================================
  Files          50       54       +4     
  Lines        3306     3721     +415     
==========================================
+ Hits         2883     3256     +373     
- Misses        245      272      +27     
- Partials      178      193      +15     
Impacted Files Coverage Δ
pkg/kms/key/creator.go 100.00% <ø> (ø)
cmd/vc-rest/startcmd/params.go 81.92% <69.23%> (-1.01%) ⬇️
pkg/kms/arieskms.go 85.18% <85.18%> (ø)
pkg/restapi/v1/issuer/controller.go 90.55% <90.36%> (-9.45%) ⬇️
pkg/restapi/resterr/handler.go 93.10% <93.10%> (ø)
pkg/doc/vc/validate.go 96.96% <93.33%> (-3.04%) ⬇️
cmd/vc-rest/startcmd/start.go 83.72% <100.00%> (+1.44%) ⬆️
pkg/did/creator.go 95.65% <100.00%> (+0.04%) ⬆️
pkg/issuer/profile.go 100.00% <100.00%> (+3.12%) ⬆️
pkg/kms/registry.go 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vkubiv vkubiv merged commit 693d946 into trustbloc:main Sep 6, 2022
@vkubiv vkubiv deleted the feat-issuer-profile-controller branch September 6, 2022 16:36
This was referenced Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants