Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixing StringTo uint32_t used only by tracing (#6883)" #7596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rvroge
Copy link

@rvroge rvroge commented Sep 4, 2024

We are running the server and core in a armv7 device.
Build for platform linux/arm/v7 failed because the reverted commit was disabling the template for 32 unsigned int variables.

This reverts commit fbe03b3.

What does the PR do?

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/core#395

Where should the reviewer start?

Test plan:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@rmccorm4 rmccorm4 added the module: platforms Issues related to platforms, hardware, and support matrix label Sep 10, 2024
@rmccorm4
Copy link
Contributor

Hi @rvroge, thanks for contributing the PR! CC'ing a couple folks who may have some more context @oandreeva-nv @nv-kmcgill53

@nv-kmcgill53
Copy link
Contributor

Just to confirm, you are wanting to build triton without tracing but you need access to the std::stoul template for your use case? We would need to confirm on our end that this change doesn't break our build with tracing enabled before merging.

@rvroge
Copy link
Author

rvroge commented Sep 11, 2024

Just to confirm, you are wanting to build triton without tracing but you need access to the std::stoul template for your use case? We would need to confirm on our end that this change doesn't break our build with tracing enabled before merging.

That's correct, we do not want to enable tracing. However, the build in our platform attempts to use the template for uint32_t (we are building for a 32 bit architecture).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: platforms Issues related to platforms, hardware, and support matrix
Development

Successfully merging this pull request may close these issues.

3 participants