-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor core input size checks #382
Conversation
…into yinggeh-DLIS-6657-client-input-byte-size-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left a question out of curiosity
…into yinggeh-DLIS-6657-client-input-byte-size-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more like a refactor than addition of client side byte size checks, Can you update the PR title to reflect the changes more accurately?
…into yinggeh-DLIS-6657-client-input-byte-size-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the LLONG_MAX
fix as well 🚀
…into yinggeh-DLIS-6657-client-input-byte-size-check
What does the PR do?
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/server#7592
Where should the reviewer start?
n/a
Test plan:
L0_input_validation--base
18114270
Caveats:
n/a
Background
n/a
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a