Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Faster compile time #819

Merged
merged 7 commits into from
Sep 7, 2017
Merged

Faster compile time #819

merged 7 commits into from
Sep 7, 2017

Conversation

sboerrigter
Copy link
Member

Fixes #794.

Changed

I've changed the following, based on issue #794:

Not changed

I did not yet look into the following points, but I created new issues for them so we can close #794 and merge this PR before we release 1.9.0.

Copy link

@luukdv luukdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I see you've removed the composer.json file. Why? Right now, the Sphynx\Installer doesn't work anymore and I'm pretty sure composer create-project trendwerk/sphynx stopped working.
  • I see you've upgraded the dependencies, can you do this with PHP too? 5.45.6
  • Did you test the upgraded dependencies like webpack-stream? gulp can't be started anymore (error), when downgrading it works again.

@sboerrigter
Copy link
Member Author

I just re-added composer.json. I thought this was only used for PHPCS 🙃.

PHP has been upgraded to 5.6.

I reverted the update commit so Webpack works again.

@sboerrigter sboerrigter merged commit e623744 into master Sep 7, 2017
@sboerrigter sboerrigter deleted the compile branch September 7, 2017 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faster compile process ⚡️
2 participants