Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verifying URL for Gitlab #3113

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Conversation

DarkaMaul
Copy link

Support GitLab.io Pages URL verification

warehouse/oidc/models/_core.py Outdated Show resolved Hide resolved
tests/unit/oidc/models/test_gitlab.py Outdated Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Outdated Show resolved Hide resolved
Copy link

@facutuesca facutuesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one final suggestion

warehouse/oidc/models/_core.py Outdated Show resolved Hide resolved
warehouse/oidc/models/github.py Outdated Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Outdated Show resolved Hide resolved
tests/unit/oidc/models/test_core.py Outdated Show resolved Hide resolved
DarkaMaul and others added 17 commits October 18, 2024 16:22
Signed-off-by: William Woodruff <[email protected]>
* docs: add security model/considerations for attestations

Signed-off-by: William Woodruff <[email protected]>

* relocate link

Signed-off-by: William Woodruff <[email protected]>

* honesty -> integrity

Signed-off-by: William Woodruff <[email protected]>

---------

Signed-off-by: William Woodruff <[email protected]>
* Add FAQ on new Trusted Publishers

* Update docs/user/trusted-publishers/internals.md

Co-authored-by: William Woodruff <[email protected]>

---------

Co-authored-by: William Woodruff <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pypi-combine-prs[bot] <144945619+pypi-combine-prs[bot]@users.noreply.github.com>
Co-authored-by: Mike Fiedler <[email protected]>
Co-authored-by: Laurent FAVOLE <[email protected]>
Co-authored-by: Maciej Olko <[email protected]>
Co-authored-by: 大王叫我来巡山 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants