Ignore ExternalName services #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspdown
added
kind/bug/fix
Ullaakut
reviewed
Jun 8, 2020
Co-authored-by: Brendan Le Glaunec <[email protected]>
Ullaakut
approved these changes
Jun 8, 2020
kevinpollet
requested changes
Jun 9, 2020
Co-authored-by: Kevin Pollet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR update the IgnoreWrapper so it ignores Services of type
ExternalName.Fixes #618
In the same time, I fixed an issue in the IgnoredWrapper on the way we handled ignored services. We weren't checking the type of the object, so if a pod had the same name as an ignored service we would have ignored it.
Some deadcode have also been removed.
How to test it
make test