Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix close socket #204

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix close socket #204

wants to merge 3 commits into from

Conversation

jan-bogaerts
Copy link

On some devices, the close method remained stuck: the UdpReceiverTask would never stop. This can be fixed by adding a timeout to the socket.

@Rapsssito
Copy link
Collaborator

Rapsssito commented Mar 22, 2022

If UdpReceiverTask never stops, it might be better to close the thread executor instead of adding a timeout to the socket.

@jan-bogaerts
Copy link
Author

If UdpReceiverTask never stops, it might be better to close the thread executor instead of adding a timeout to the socket.

not really cause internally, the socket will still not be closed.

@Rapsssito
Copy link
Collaborator

@jan-bogaerts, oh, I understand. Then, the issue is how the task is being handled. I will try to add a thread handler asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants