Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httputil: Fix quadratic performance of cookie parsing #3446

Merged
merged 3 commits into from
Nov 22, 2024
Merged

httputil: Fix quadratic performance of cookie parsing #3446

merged 3 commits into from
Nov 22, 2024

Commits on Nov 22, 2024

  1. httputil: Fix quadratic performance of cookie parsing 

    Maliciously-crafted cookies can cause Tornado to
spend an unreasonable amount of CPU time and block
the event loop.

This change replaces the quadratic algorithm with
a more efficient one. The implementation is copied
from the Python 3.13 standard library (the
previous one was from Python 3.5).

Fixes CVE-2024-52804
See CVE-2024-7592 for a similar vulnerability in cpython.

Thanks to github.com/kexinoh for the report.
    @bdarnell
    bdarnell committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d5ba4a1 View commit details
    Browse the repository at this point in the history

  2. Fix tests with Twisted 24.7.0 

    `twisted.internet.defer.returnValue` was needed on Python 2, but on
Python 3 a simple `return` statement works fine.  Twisted 24.7.0
deprecated the former, causing
`tornado.test.twisted_test.ConvertDeferredTest.test_success` to fail.
    @cjwatson @bdarnell
    cjwatson authored and bdarnell committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bc7df6b View commit details
    Browse the repository at this point in the history

  3. Bump version to 6.4.2

    @bdarnell
    bdarnell committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a5ecfab View commit details
    Browse the repository at this point in the history