Extract abstract base test logic from UnixSocketTest #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, these tests were named backwards.
This makes the pattern reusable (and discoverable) for other tests. Also exclude these skipped tests from the reporting that is meant to highlight environmental issues. This could potentially move to tornado.testing (or even upstream to the stdlib) if it proves generally useful.
Removes some typing-related hacks, but unfortunately introduces another MRO-related hack.
All but one implementation of this mixin has been removed, so we no longer need the abstraction.
The get_ssl_version method in these tests has been silently ignored for a long time (forever?) due to MRO issues (if they weren't ignored, they'd have started throwing deprecation warnings), and they were never updated for more recent versions of TLS. There doesn't appear to be much value in rehabilitating these tests so just get rid of all but the base configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt it everywhere we use this pattern and pull on some loose threads along the way.
This change improves type-checking coverage and improves compatibility with alternative test runners such as pytest. However, it may increase the number of skipped tests reported in some environments.