Revert "asyncio: Remove atexit hook" #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarnell
force-pushed
the
selector-thread-atexit
branch
7 times, most recently
from
0e47fb9
to
120c97a
Compare
This reverts commit 6236374. We are again seeing hangs at shutdown in SyncHTTPClientTest.test_destructor_log. Maybe putting this back will help.
If this executor was left around it would be GC'd at an unpredictable time and would often be reported as a failure in other circlerefs tests. (For unknown reasons this would occur most often in i686 (i.e. 32-bit) linux builds).
bdarnell
force-pushed
the
selector-thread-atexit
branch
from
120c97a
to
3340c39
Compare
|
This passed a bunch of runs with the build.yml workflow so looks like it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6236374.
We are again seeing hangs at shutdown in
SyncHTTPClientTest.test_destructor_log. Maybe putting this back will
help.