Remove invalid database names from dropdown suggestions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the cli translation of the sqlalchemy query: SELECT DISTINCT query_database FROM query_revision
JOIN query_run ON query_revision.id = query_rev_id
WHERE extra_info NOT LIKE "{\"error%"
AND query_database IS NOT NULL |
siddharthvp
force-pushed
the
invalid-suggestions
branch
2 times, most recently
from
7a2dec8
to
11b644c
Compare
This is done by only including dbs against which successful queries have been run in the past. Also add a Cache-Control header is response so the result is cached in the browser for one hour or till a hard reload is done. Bug: T289943
siddharthvp
force-pushed
the
invalid-suggestions
branch
from
11b644c
to
f36ec68
Compare
vivian-rook
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by only including dbs against which successful queries have been run in the past.
Also add a Cache-Control header is response so the result is cached in the browser for one hour or till a hard reload is done.
Bug: T289943