Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress E_WARNING #1091

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Commits on Aug 7, 2024

  1. [BUGFIX] don't convert empty string

    Fixes tomasnorre#1087
    
    Return early on empty $dataString as this can't be
    an array in any case.
    ulrichmathes committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4d508de View commit details
    Browse the repository at this point in the history
  2. [BUGFIX] suppress unserialize E_WARNINGS

    Fixes tomasnorre#1087
    
    The intention of the try-catch block was to
    catch Throwables during the unserialization of $dataString.
    
    However, unserialize only throws exceptions when the
    initialization of objects fails. With 'allowed_classes' => false,
    no objects will be initialized.
    
    Since PHP 8.3, an E_WARNING is issued if the string
    is not unserializable. As we are not certain
    if the string contains serialized data, we only want
    to attempt to unserialize it.
    
    To prevent E_WARNINGS, we need to suppress errors
    instead of using try-catch.
    ulrichmathes committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d7fcfb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    457754b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    f36836a View commit details
    Browse the repository at this point in the history