Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "crawler:buildQueue fails with Error at offset 0 of 92 bytes" #1088

Open
wants to merge 1 commit into
base: v11.x
Choose a base branch
from

Conversation

stephan-brun
Copy link

Fix #1087

@tomasnorre
Copy link
Owner

First, thanks a lot for providing the PR.
To be honest. I have see this behavior before and tried to change the order of the if-checks, but gave other side effects. I don't recall from the top of my head, but some unwanted effects was present. I need to dig into this a little more again to validate the PR.

From a logical perspective, your check first sounds reasonable, as the converter is only there, is old data format is still present in queue, which shouldn't happen that often, only directly after an update.

So perhaps in Idea that I should consider implement, in the dev-main branch, as v11.x only get bugs fixes. Would be to make a command that updates the format ones, and remove the converter.

What do you think @stephan-brun @hacksch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants