Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency on :crypto app #45

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

jvantuyl
Copy link
Contributor

@jvantuyl jvantuyl commented Sep 1, 2023

The private Holidefs.Holiday.generate_uid/3 function uses :crypto.hash/2.

The :crypto module is part of an application of the same name. Since a dependency is not specified, it's possible for the app to not be started yet when that function is called.

This PR declares the dependency explicitly in mix.exs.

Copy link
Contributor

@kelvinst kelvinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@lukyanov lukyanov merged commit 4f9b118 into toggl:master Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants