Allow one reviewer for CMakeLists.txt files #7499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filters out `CMakeLists.txt` files from the list of files that require two reviewers.
|
@erimatnor, @svenklemm: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7499 +/- ##
==========================================
+ Coverage 80.06% 82.17% +2.10%
==========================================
Files 190 230 +40
Lines 37181 43188 +6007
Branches 9450 10867 +1417
==========================================
+ Hits 29770 35490 +5720
- Misses 2997 3377 +380
+ Partials 4414 4321 -93 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Nov 28, 2024
fabriziomello
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I'm not a fan of adding a lot of exceptions on the workflow. We already have the pr approval workflow and a way to bypass it requiring only one approval?? Why add more and more exceptions... it is better to you judge that the change is simply enough to require only one approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filters out
CMakeLists.txtfiles from the list of files that require two reviewers.Disable-check: force-changelog-file