Fix show_chunks on hypertable by hash #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
13b6745
to
0864cb1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
==========================================
+ Coverage 80.06% 81.74% +1.68%
==========================================
Files 190 199 +9
Lines 37181 37026 -155
Branches 9450 9680 +230
==========================================
+ Hits 29770 30268 +498
+ Misses 2997 2863 -134
+ Partials 4414 3895 -519 ☔ View full report in Codecov by Sentry. |
svenklemm
reviewed
Jun 1, 2024
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
0864cb1
to
464cf15
Compare
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
2 times, most recently
from
021e98d
to
40883c1
Compare
nikkhils
reviewed
Jun 5, 2024
test/expected/chunk_utils.out
Outdated
| -- Hypertable by hash partitioning | ||
| CREATE TABLE test_by_hash (id BIGINT, value FLOAT8); | ||
| SELECT create_hypertable('test_by_hash', by_hash('id', 10)); | ||
| create_hypertable |
There was a problem hiding this comment.
@fabriziomello with my PR #6993 we won't allow creation of hypertable with by_hash.
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
40883c1
to
3a7611b
Compare
svenklemm
approved these changes
Jun 5, 2024
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
3a7611b
to
1109d85
Compare
nikkhils
reviewed
Jun 5, 2024
src/chunk.c
Outdated
| time_dim = hyperspace_get_closed_dimension(ht->space, 0); | ||
|
|
||
| Ensure(time_dim != NULL, | ||
| "time dimension not found for hypertable \"%s\".\"%s\"", |
There was a problem hiding this comment.
@fabriziomello should the message be: "partitioning dimesion not found for hypertable"?
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
1109d85
to
e38bee4
Compare
Using the new hypertable API creating closed dimentions when partitioning by hash was leading to a segfault on show_chunks. Fixed it by checking for the closed primary dimension and erroring out in case of using parameters `older_than` and `newer_than`.
fabriziomello
force-pushed
the
fix_show_chunks_on_hypertable_by_hash
branch
from
e38bee4
to
ee88a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new hypertable API creating closed dimentions when partitioning by hash was leading to a segfault on show_chunks.
Fixed it by checking for the closed primary dimension and erroring out in case of using parameters
older_thanandnewer_than.Disable-check: force-changelog-file