Feature/kebechet analysis specific day #411
Conversation
sesheta
added
the
size/M
srcopsmetrics/cli.py
Outdated
| @@ -160,9 +161,12 @@ def cli( | |||
| for project in repos: | |||
| os.environ["PROJECT"] = project | |||
|
|
|||
| today = date.today() | |||
| yesterday = today.replace(day=today.day - 1) | |||
There was a problem hiding this comment.
This is going to give error, if you don't change also month and eventually year.
For example today is 2021-06-01, if you run yesterday = today.replace(day=today.day - 1) you will get error: ValueError: day is out of range for month, unless you change also month and you will get problem with year on 2022-01-01.
A more robust/easier solution is to use:
from datetime import date, timedelta
today = date.today()
yesterday = today - timedelta(days=1)
which returns correctly 2021-05-31
srcopsmetrics/kebechet_metrics.py
Outdated
| file_name += ".json" | ||
|
|
||
| KnowledgeStorage(is_local=self.is_local).save_data(file_path=path.joinpath(file_name), data=stats) | ||
|
|
||
| @staticmethod | ||
| def merge_kebechet_metrics_today(is_local: bool = False): | ||
| def merge_kebechet_metrics_for_day(day: date, is_local: bool = False): |
There was a problem hiding this comment.
might be per_day instead of for_day in this case.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xtuchyna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Related Issues and Dependencies
Related to thoth-station/thoth-application#1500 (comment)
and thoth-station/mi-scheduler#131
and thoth-station/kebechet#546
This introduces a breaking change
This Pull Request implements
Instead of using today's date as default, user needs to specify now from which date the kebechet statistics will be collected.
This allows us an inspection of yesterday's data for kebechet stats, so that we can merge all the collected data for a SLI/SLO metrics on how the kebechet did the day before.