Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to rectify oddities in the fsharp giraffe benchmarks (giraffe, giraffe-endpoints) that likely led to its unusually poor results.
The fix to each is to clear the default logging providers - presumably this removes a good amount of processing / IO which leads to better request / response performance.
Why is this okay? Is this cheating?
I believe this is okay because this seems to be the standard for dotnet benchmarks (fsharp and csharp) - both in this repo and in others (like tech empower).
It is a little sus (idk if other languages are doing this) but it will at least get these benchmarks in parity with others on the same tech stack.
fsharp:
csharp:
aspnet-minimal-api - clears - https://github.com/the-benchmarker/web-frameworks/blob/master/fsharp/websharper/Main.fs#L44
tech empower
References