Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add instructions for deployment using GitHub Actions #955

Merged
merged 28 commits into from
Nov 28, 2023
Merged

feat: add instructions for deployment using GitHub Actions #955

merged 28 commits into from
Nov 28, 2023

Conversation

daniel-cit
Copy link
Contributor

This pull request adds support for deployment of the terraform Example Foundation using GitHub Actions

@daniel-cit daniel-cit marked this pull request as ready for review April 20, 2023 21:46
@daniel-cit daniel-cit requested review from a team and rjerrems as code owners April 20, 2023 21:46
@bharathkkb
Copy link
Member

/gcbrun

bharathkkb
bharathkkb reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit a few comments

0-bootstrap/github.tf.example Show resolved Hide resolved
0-bootstrap/github.tf.example Outdated Show resolved Hide resolved
0-bootstrap/terraform.example.tfvars Outdated Show resolved Hide resolved
0-bootstrap/variables.tf Outdated Show resolved Hide resolved
build/github-tf-apply.yaml Outdated Show resolved Hide resolved
build/github-tf-plan.yaml Outdated Show resolved Hide resolved
build/tf-wrapper.sh Outdated Show resolved Hide resolved
build/github-tf-plan.yaml Outdated Show resolved Hide resolved
@daniel-cit daniel-cit requested a review from bharathkkb May 9, 2023 02:51
rjerrems
rjerrems approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - If @bharathkkb has time, it would be worthwhile having him cast his eyes over this before merging.

gtsorbo
gtsorbo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! LGTM

@apeabody apeabody merged commit 56450bd into terraform-google-modules:master Nov 28, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Nov 28, 2023
Merged
@mikebridge
Copy link

This looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@gtsorbo gtsorbo gtsorbo approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daniel-cit @bharathkkb @mikebridge @gtsorbo @rjerrems @apeabody