Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix project labels #1107

Merged
merged 37 commits into from
Apr 9, 2024
Merged

chore: Fix project labels #1107

merged 37 commits into from
Apr 9, 2024

Conversation

mariammartins
Copy link
Contributor

Hello folks,

This PR contains:

  • changes in environment and env_code project labels

  • change the variable from vpc_type to vpc

  • Adding the use of the string "nul" in the vpc variable when the projects does not have a network

@mariammartins mariammartins changed the title Fix project labels chore: Fix project labels Feb 6, 2024
@mariammartins mariammartins marked this pull request as draft February 6, 2024 18:51
@mariammartins mariammartins reopened this Feb 6, 2024
@mariammartins mariammartins reopened this Feb 7, 2024
@mariammartins mariammartins marked this pull request as ready for review February 7, 2024 16:59
@Samir-Cit
Copy link
Contributor

/gcbrun

@mariammartins
Copy link
Contributor Author

/gcbrun

1 similar comment
@romanini-ciandt
Copy link
Member

/gcbrun

apeabody
apeabody reviewed Feb 7, 2024
View reviewed changes
0-bootstrap/variables.tf Outdated Show resolved Hide resolved
renato-rudnicki
renato-rudnicki reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@renato-rudnicki renato-rudnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes. LGTM

@mariammartins mariammartins marked this pull request as draft February 7, 2024 19:52
@mariammartins mariammartins marked this pull request as ready for review February 8, 2024 14:46
@apeabody
Copy link
Contributor

apeabody commented Feb 8, 2024

/gcbrun

@romanini-ciandt
Copy link
Member

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

1 similar comment
@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@romanini-ciandt
Copy link
Member

/gcbrun

@apeabody apeabody merged commit eb28ecb into terraform-google-modules:master Apr 9, 2024
6 checks passed
@release-please release-please bot mentioned this pull request Apr 9, 2024
Merged
This was referenced Apr 25, 2024
Closed
Closed
@obriensystems
Copy link
Contributor

https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/access_context.auto.tfvars

-../../access_context.auto.tfvars
+../shared/access_context.auto.tfvars

there is a 2nd symlink regression in the same directory in
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/common.auto.tfvars

-../../common.auto.tfvars
+../shared/common.auto.tfvars

I'll raise an issue shortly with the fix after I test a full upstream sync of the TEF.

@obriensystems obriensystems mentioned this pull request May 11, 2024
Closed
@fmichaelobrien fmichaelobrien mentioned this pull request May 12, 2024
Closed
@fmichaelobrien
Copy link
Contributor

See #1229

@fmichaelobrien fmichaelobrien mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanini-ciandt romanini-ciandt romanini-ciandt left review comments

@renato-rudnicki renato-rudnicki renato-rudnicki left review comments

@daniel-cit daniel-cit daniel-cit left review comments

@apeabody apeabody apeabody left review comments

@eeaton eeaton eeaton approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo gtsorbo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mariammartins @Samir-Cit @romanini-ciandt @apeabody @renato-rudnicki @daniel-cit @obriensystems @fmichaelobrien @eeaton