Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for fine grained configuration of VPC-flow logs #1035

Merged
merged 11 commits into from
Dec 13, 2023
Merged

feat: add support for fine grained configuration of VPC-flow logs #1035

merged 11 commits into from
Dec 13, 2023

Conversation

daniel-cit
Copy link
Contributor

This PR adds support for fine grained configuration of VPC-flow logs

@daniel-cit daniel-cit requested review from rjerrems, gtsorbo and a team as code owners November 22, 2023 19:55
jasonbisson
jasonbisson reviewed Dec 4, 2023
View reviewed changes
Copy link

@jasonbisson jasonbisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files changes look good to me, but looks like there is problem with the build.

@daniel-cit
Copy link
Contributor Author

The files changes look good to me, but looks like there is problem with the build.

@jasonbisson build is green :)

jasonbisson
jasonbisson approved these changes Dec 5, 2023
View reviewed changes
Copy link

@jasonbisson jasonbisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gtsorbo
gtsorbo approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-cit
Copy link
Contributor Author

@apeabody @gtsorbo green build 🎉

@gtsorbo gtsorbo merged commit ee3a1d8 into terraform-google-modules:master Dec 13, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbisson jasonbisson jasonbisson approved these changes

@gtsorbo gtsorbo gtsorbo approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-cit @gtsorbo @jasonbisson