-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace text example of private key with an image in the jenkins readme #1027
fix: replace text example of private key with an image in the jenkins readme #1027
Conversation
/gcbrun |
@gtsorbo this Pull request is documentation only. |
If someone opens a PR for the trigger exclusion I can review it: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/terraform/test-org/ci-triggers/triggers.tf#L422 |
GoogleCloudPlatform/cloud-foundation-toolkit#2028 for your consideration @apeabody |
Thanks! I've merged GoogleCloudPlatform/cloud-foundation-toolkit#2027 and applied the update to the triggers. |
This PR replaces the text example of a RSA private key with an image in the Jenkins readme to prevent.
This example of a RSA private key may trigger a validation when pushing code to source repo to prevent exposure of private keys.
fixes #1014