Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload junit XML files #6679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only upload junit XML files #6679

wants to merge 1 commit into from

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Oct 19, 2024

There are many large coverage files in the zip archives which we don't want to have to download when we are only interested in accessing junit XMLs:

$ gh run download 11404810538 --repo temporalio/temporal --dir .
$ fd --type f --exec du -ah {} | sort -rh

3.7M    ./junit-xml--11404810538--1--postgres12_pgx--functional-test-xdc/90b64926828a35a7fa7d0abe4e47fb81.cover.out
...30 like this...
3.6M    ./junit-xml--11404810538--1--cass_es--functional-test-ndc/1489124e0ff5f88db39decd3857743e3.cover.out
3.3M    ./junit-xml--11404810538--1--unit-test/e79e1deb24d801f1386c6d15fa8aa9b8.cover.out
2.9M    ./junit-xml--11404810538--1--integration-test/ec6be7e1fa51451d8af37c9645ed1ec2.cover.out
884K    ./junit-xml--11404810538--1--unit-test/9721157f8b693ef10498237f1c2a6815.junit.xml
412K    ./junit-xml--11404810538--1--integration-test/832a9ed3484a3b633106f01aac17822a.junit.xml
272K    ./junit-xml--11404810538--1--ubuntu-20.04--cass_es8--2--functional-test/80d320ae0fb05f84e633c54af2f222f7.junit.xml
260K    ./junit-xml--11404810538--1--postgres12_pgx--functional-test-xdc/49b18d5cb0cf6427a3c5cd645ac3ab8c.junit.xml

However, there are also a few very large junit XMLs, in which complete logging output has been captured in the <failure message="Failed" type=""> field.

8.4M    ./junit-xml--11404810538--1--ubuntu-20.04--sqlite--2--functional-test/053f83e6a8000b581a749edd016398ba.junit.xml

It would be good to prevent creation of these large XMLs in a subsequent PR.

@dandavison dandavison marked this pull request as ready for review October 19, 2024 13:00
@dandavison dandavison requested a review from a team as a code owner October 19, 2024 13:00
There are many large coverage files which we want to exclude when
retrieving multiple artifacts in order to access junit XMLs:

$ gh run download 11404810538 --repo temporalio/temporal --dir .

3.7M    ./junit-xml--11404810538--1--postgres12_pgx--functional-test-xdc/90b64926828a35a7fa7d0abe4e47fb81.cover.out
...30 like this...
3.6M    ./junit-xml--11404810538--1--cass_es--functional-test-ndc/1489124e0ff5f88db39decd3857743e3.cover.out
3.3M    ./junit-xml--11404810538--1--unit-test/e79e1deb24d801f1386c6d15fa8aa9b8.cover.out
2.9M    ./junit-xml--11404810538--1--integration-test/ec6be7e1fa51451d8af37c9645ed1ec2.cover.out
884K    ./junit-xml--11404810538--1--unit-test/9721157f8b693ef10498237f1c2a6815.junit.xml
412K    ./junit-xml--11404810538--1--integration-test/832a9ed3484a3b633106f01aac17822a.junit.xml
272K    ./junit-xml--11404810538--1--ubuntu-20.04--cass_es8--2--functional-test/80d320ae0fb05f84e633c54af2f222f7.junit.xml
260K    ./junit-xml--11404810538--1--postgres12_pgx--functional-test-xdc/49b18d5cb0cf6427a3c5cd645ac3ab8c.junit.xml

However, there are also a few very large junit XMLs, in which complete
logging output has been captured in the <failure message="Failed"
type=""> field.

8.4M    ./junit-xml--11404810538--1--ubuntu-20.04--sqlite--2--functional-test/053f83e6a8000b581a749edd016398ba.junit.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant