files: Move the files viewer and selection bits to a separate widget #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation here is to break down the application into smaller modules that are logically isolated and therefore easier to maintain. This change: * Moves all the files viewing and selection UI components to a single PortfolioFiles widget. * Keep the overall window nagivation and operations-activation logic to the existing PortfolioWindow widget. Isolating files viewing and selection components to a separate widget will also make it easier to port this app to GTK4 and Libadwaita, later. Issue #290
This is just a minimal port of these tests. Long-term these tests should be split in two, one for window navigation and another for files viewer specifics. Closes #290
tchx84
force-pushed
the
issue-290-part6-v2
branch
from
4939945
to
b421c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #290