Add initial tests for the "iterator-sequencing" proposal #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Almost all of these tests pass verbatim on my polyfill, which is great!
I've commented the ones that don't - I assume they represent bugs in my polyfill, but I'll do a deep dive on the spec text to make sure.
update: one set of them was a bug that disappeared when i rewrote the implementation to match the spec text.
ljharb
reviewed
Nov 14, 2024
test/built-ins/Iterator/concat/throws-typeerror-when-generator-is-running-return.js
Show resolved
Hide resolved
ljharb
added a commit
to es-shims/iterator-helpers
that referenced
this pull request
Nov 15, 2024
ljharb
added a commit
to es-shims/iterator-helpers
that referenced
this pull request
Nov 15, 2024
ljharb
added a commit
to es-shims/iterator-helpers
that referenced
this pull request
Nov 15, 2024
test/built-ins/Iterator/concat/throws-typeerror-when-iterable-not-an-object.js
Show resolved
Hide resolved
| assert.sameValue(iterResult.done, false); | ||
| assert.sameValue(iterResult.value, 123); | ||
|
|
||
| assert.notSameValue(iterResult, oldIterResult); |
There was a problem hiding this comment.
This seems unnecessarily wasteful. I've opened an issue to reconsider this behaviour: tc39/proposal-iterator-sequencing#17
michaelficarra
approved these changes
Nov 19, 2024
|
I pushed up a couple of commits. This LGTM now, modulo the normative question which we can resolve at the upcoming plenary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are based on existing tests in "test/built-ins/Iterator".