Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Recommend "remapping" for dates exceeding era year bounds #2986

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

gibson042
Copy link
Collaborator

Fixes #2865

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (8c70250) to head (0740c3b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   96.35%   96.40%   +0.04%     
==========================================
  Files          21       21              
  Lines       10519    10575      +56     
  Branches     1803     1808       +5     
==========================================
+ Hits        10136    10195      +59     
+ Misses        325      322       -3     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all looks good to me.

I guess we have no test262 coverage for this. Are you interested in adding some?

spec/calendar.html Outdated Show resolved Hide resolved
@ptomato ptomato mentioned this pull request Oct 1, 2024
27 tasks
Co-authored-by: Philip Chimento <[email protected]>
@gibson042
Copy link
Collaborator Author

I guess we have no test262 coverage for this. Are you interested in adding some?

I don't think I'll have availability for that until after the upcoming meeting, so feel free to jump ahead if you can.

@ptomato ptomato merged commit 1c6b860 into tc39:main Oct 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CalendarDateToISO: Constrain behaviour for regnal years?
2 participants